Deprecate .Values.global.connectivity.network.allowAllEgress #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @nprokopic, a test pull request has been created for you in the cluster-aws repo! Go to pull request giantswarm/cluster-aws#754 in order to test your cluster chart changes on AWS. |
T-Kukawka
approved these changes
Aug 8, 2024
fiunchinho
approved these changes
Aug 8, 2024
vxav
approved these changes
Aug 8, 2024
weseven
approved these changes
Aug 8, 2024
|
There were no differences in the rendered Helm template. Output |
|
Hey @nprokopic, a test pull request has been created for you in the cluster-aws repo! Go to pull request giantswarm/cluster-aws#756 in order to test your cluster chart changes on AWS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR deprecates the usage of
.Values.global.connectivity.network.allowAllEgress.Currently the default flag value is
false, which means thatnetwork-policiesapp will get installed, which is desired. Setting this flag to true means thatnetwork-policiesapp is not installed, and we shouldn't disable network-policies like that anymore.What is the effect of this change to users?
Public API (global Helm value) that can disable netowork-policies app has been deprecated and should not be used anymore.
Any background context you can provide?
Had more than few chats about network policies with KaaS folks. It all started here giantswarm/roadmap#3125.
It looks like that the transition to Cilium network policies has left quite a few leftover configs across multiple (cluster-<provider>) apps.
I will open a similar PR in cluster-aws and cluster-azure.
cluster-vsphere has a similar flag
.internal.ciliumNetworkPolicies.enabledwhich is being removed here.What is needed from the reviewers?
Does this deprecation make sense? Do we still need this flag?
Should this change be mentioned in the release notes?